Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propose changes to cutadapt #26

Merged
merged 11 commits into from
Feb 27, 2024
Merged

Propose changes to cutadapt #26

merged 11 commits into from
Feb 27, 2024

Conversation

rcannood
Copy link
Contributor

@rcannood rcannood commented Feb 22, 2024

Description

  • Change multiple_sep to ;
  • Simplify processing of multiple input arguments using a helper functions
  • Use .fasta as an extension if --fasta is set, otherwise use .fastq
  • Refactor processing of output arguments
  • Write custom tests to better understand and check where different reads are going.

Issue ticket number

Closes #xxxx

Checklist before requesting a review

  • I have performed a self-review of my code

  • Conforms to the Contributing guidelines

  • Proposed changes are described in the CHANGELOG.md

  • I have tested my code with viash ns test --parallel -q <name or namespace>

  • Check the correct box. Does this PR contain:

    • Breaking changes
    • New functionality
    • Major changes
    • Minor changes
    • Documentation
    • Bug fixes

@rcannood rcannood changed the title Dev/cutadapt pr Propose changes to cutadapt Feb 22, 2024
@rcannood rcannood marked this pull request as ready for review February 24, 2024 21:25
@rcannood rcannood requested a review from tverbeiren February 24, 2024 21:25
@tverbeiren
Copy link
Contributor

Thanks for this, @rcannood !

I wonder though, what about the open comments in #7?

@rcannood
Copy link
Contributor Author

Oops. My comments were still stuck in "Pending". Luckily GitHub remembers what I wrote.

This PR didn't intend to solve the open comment related to the output directory.

@rcannood rcannood merged commit 35e7f3c into dev/cutadapt Feb 27, 2024
6 checks passed
@rcannood rcannood deleted the dev/cutadapt_pr branch February 27, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants